Re: Fwd: [Patch Review] TRUNCATE Permission - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Fwd: [Patch Review] TRUNCATE Permission
Date
Msg-id 603c8f070809052013l2f350eecn15c21d490a8f6d18@mail.gmail.com
Whole thread Raw
In response to Re: Fwd: [Patch Review] TRUNCATE Permission  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fwd: [Patch Review] TRUNCATE Permission  ("Ryan Bradetich" <rbradetich@gmail.com>)
Re: Fwd: [Patch Review] TRUNCATE Permission  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Updated patch attached, based on comments from Ryan Bradetich and Tom
Lane, and sync'd to latest CVS version.

...Robert

On Mon, Sep 1, 2008 at 9:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Ryan Bradetich" <rbradetich@gmail.com> writes:
>> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> [ something about "your patch" ]
>
>> This is Robert Haas's patch for the September 2008 commit-fest.
>> I am just offering my review.
>
> Sorry about that, I got confused by the reply-to-a-reply.
>
>> Does my first suggestion still make sense for removing the TRUNCATE in
>> pg_class_aclmask() when pg_Authid.rolcatupdate is not set?
>
> Probably.  AFAICS it should be treated exactly like ACL_DELETE, so
> anyplace that acl-whacking code is doing something for ACL_DELETE and
> the patch doesn't add in ACL_TRUNCATE, I'd be suspicious ...
>
>                        regards, tom lane
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: New FSM allocation policy
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] "\ef " in psql