Re: Fwd: [Patch Review] TRUNCATE Permission - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fwd: [Patch Review] TRUNCATE Permission
Date
Msg-id 1872.1220319234@sss.pgh.pa.us
Whole thread Raw
In response to Fwd: [Patch Review] TRUNCATE Permission  ("Ryan Bradetich" <rbradetich@gmail.com>)
Responses Re: Fwd: [Patch Review] TRUNCATE Permission  ("Robert Haas" <robertmhaas@gmail.com>)
List pgsql-hackers
"Ryan Bradetich" <rbradetich@gmail.com> writes:
> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> [ something about "your patch" ]

> This is Robert Haas's patch for the September 2008 commit-fest.
> I am just offering my review.

Sorry about that, I got confused by the reply-to-a-reply.

> Does my first suggestion still make sense for removing the TRUNCATE in
> pg_class_aclmask() when pg_Authid.rolcatupdate is not set?

Probably.  AFAICS it should be treated exactly like ACL_DELETE, so
anyplace that acl-whacking code is doing something for ACL_DELETE and
the patch doesn't add in ACL_TRUNCATE, I'd be suspicious ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: [gsmith@gregsmith.com: Re: [patch] GUC source file and line number]
Next
From: "Jaime Casanova"
Date:
Subject: Re: [PATCH] allow has_table_privilege(..., 'usage') on sequences