Re: [PoC] pgstattuple2: block sampling to reduce physical read - Mailing list pgsql-hackers

<div class="WordSection1"><p class="MsoNormal"> <p class="MsoNormal">On 16/09/13 16:20, Satoshi Nagayasu wrote:<p
class="MsoNormal">>Thanks for checking. Fixed to eliminate SnapshotNow.<p class="MsoNormal"> <p
class="MsoNormal">Lookingforward to get a new patch, incorporating the comments, that are already given in the
followingmails:<p class="MsoNormal"> <p class="MsoNormal">1. Jaime Casanova: "The name pgstattuple2, doesn't convince
me...maybe you can use pgstattuple() if you use a second argument (percentage of the sample) to overload the function".
<pclass="MsoNormal">(<a
href="http://www.postgresql.org/message-id/5265AD16.3090704@catalyst.net.nz">http://www.postgresql.org/message-id/5265AD16.3090704@catalyst.net.nz</a>)
<pclass="MsoNormal"> <p class="MsoNormal">The comment related to having an argument, to mention the sampling number, is
alsogiven by Greg Smith: “There should be an input parameter to the function for how much sampling to do”<p
class="MsoNormal">(<a
href="http://www.postgresql.org/message-id/51EE62D4.7020401@2ndQuadrant.com">http://www.postgresql.org/message-id/51EE62D4.7020401@2ndQuadrant.com</a>)
<pclass="MsoNormal"> <p class="MsoNormal">2. Yourself: "I think it could be improved by sorting sample block numbers
beforephysical block reads in order to eliminate random access on the disk." <p class="MsoNormal">(<a
href="http://www.postgresql.org/message-id/525779C5.2020608@uptime.jp">http://www.postgresql.org/message-id/525779C5.2020608@uptime.jp</a>)
forwhich, Mark Kirkwood , has given a rough patch.<p class="MsoNormal"> <p class="MsoNormal">Regards,<p
class="MsoNormal">FirozEV<p class="MsoNormal"> </div>