Re: xact_desc - Mailing list pgsql-hackers

From Tom Lane
Subject Re: xact_desc
Date
Msg-id 5820.1223953547@sss.pgh.pa.us
Whole thread Raw
In response to xact_desc  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: xact_desc
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> ISTM that xact_desc routines do not work properly when called with
> WAL_DEBUG enabled from XLogInsert().

Well, now that you mention it, that code is utterly, completely broken,
and always has been.  It's passing only the first rdata-chunk of the WAL
record to the print routine :-(

AFAICS the only way to fix it would be to allocate some workspace and
assemble the chunks of the record into that.  Doubtful that it's worth
it --- I'd be inclined to just remove the code instead.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: xact_desc
Next
From: KaiGai Kohei
Date:
Subject: Re: Updates of SE-PostgreSQL 8.4devel patches