Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit() - Mailing list pgsql-committers

From Teodor Sigaev
Subject Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Date
Msg-id 56EAE9D5.9020203@sigaev.ru
Whole thread Raw
In response to Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
> If that's to be an actual GUC variable, it's not okay for set_limit()
> to just do this:
>
>     similarity_threshold = nlimit;
>
> It should go through SetConfigOption(); compare for example
> tsa_set_curcfg_byname().  Which would also mean you could drop the
> range-checking code there, because guc.c would enforce it.

will fix

--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Next
From: Teodor Sigaev
Date:
Subject: Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()