Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit() - Mailing list pgsql-committers

Teodor Sigaev <teodor@sigaev.ru> writes:
> GUC variable pg_trgm.similarity_threshold insead of set_limit()

If that's to be an actual GUC variable, it's not okay for set_limit()
to just do this:

    similarity_threshold = nlimit;

It should go through SetConfigOption(); compare for example
tsa_set_curcfg_byname().  Which would also mean you could drop the
range-checking code there, because guc.c would enforce it.

            regards, tom lane