On 2016/01/21 7:04, Alvaro Herrera wrote:
> Etsuro Fujita wrote:
>> On second thought, I noticed that detecting whether we see a system column
>> that way needs more cycles in cases where the reltargetlist and the
>> restriction clauses don't contain any system columns. ISTM that such cases
>> are rather common, so I'm inclined to keep that code as-is.
> Ah, I see now what you did there. I was thinking you'd have the
> foreach(restrictinfo) loop, then once the loop is complete scan the
> bitmapset; not scan the bitmap set scan inside the other loop.
Ah, I got to the point. I think that is a good idea. The additional
cycles for the worst case are bounded and negligible. Please find
attached an updated patch.
Best regards,
Etsuro Fujita
