Re: onlyvalue aggregate (was: First Aggregate Funtion?) - Mailing list pgsql-hackers

From Marko Tiikkaja
Subject Re: onlyvalue aggregate (was: First Aggregate Funtion?)
Date
Msg-id 5637422B.4090203@joh.to
Whole thread Raw
In response to Re: onlyvalue aggregate (was: First Aggregate Funtion?)  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: onlyvalue aggregate (was: First Aggregate Funtion?)  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
On 11/2/15 9:32 AM, Dean Rasheed wrote:
> On 28 October 2015 at 16:50, Marko Tiikkaja <marko@joh.to> wrote:
>> Here's a patch for the aggregate function outlined by Corey Huinker in
>> CADkLM=foA_oC_Ri23F9PbfLnfwXFbC3Lt8bBzRu3=CB77G9_qw@mail.gmail.com .
>
> +1. I've wanted something like this a few times. Of the names
> suggested so far, I think I prefer "single_value", and yes I think it
> should work with NULLs.

This was actually a last-minute design change I made before submitting 
the patch.  The two times I've previously written this aggregate both 
accepted NULLs and only enforced that there must not be more than one 
non-NULL value, but that's only because I was thinking about the "poor 
man's FILTER" case, which is obsolete since version 9.4.  The reason I 
changed in this version is that accepting NULLs can also hide bugs, and 
it's (usually) easy to filter them out with FILTER.

Did you have some specific use case in mind where accepting NULLs would 
be beneficial?


.m



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: onlyvalue aggregate (was: First Aggregate Funtion?)
Next
From: Alexander Korotkov
Date:
Subject: Re: WIP: Access method extendability