Re: Logical tape pause/resume - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Logical tape pause/resume
Date
Msg-id 55b3b7ae-8dec-b188-b8eb-e07604052351@iki.fi
Whole thread Raw
In response to Re: Logical tape pause/resume  (Peter Geoghegan <pg@heroku.com>)
Responses Re: [HACKERS] Logical tape pause/resume  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On 10/10/2016 10:31 PM, Peter Geoghegan wrote:
> On Sun, Oct 9, 2016 at 11:52 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Ok, good. I think we're in agreement on doing this, then, even if we don't
>> agree on the justification :-).
>
> Agreed. :-)

Attached are new patch versions. Rebased them over current head, fixed a
number of bugs in the seek and backspace code, and did a bunch of
stylistic cleanups and comment fixes.

I changed the API of LogicalTapeBackspace() slightly. If you try to back
up beyond the beginning of tape, it used to return FALSE and do nothing.
Now it backspaces as much as it can, to the very beginning of the tape,
and returns the amount backspaced. That was more convenient than the old
behaviour with this new implementation.

- Heikki


Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1
Next
From: Peter Eisentraut
Date:
Subject: Re: Remove "Source Code" column from \df+ ?