Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res
Date
Msg-id 55F6DF96.1060604@sigaev.ru
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
>      /*
> -    * We use UNION ALL rather than UNION; this might sometimes result in
> -    * duplicate entries in the OID list, but we don't care.
> +    * this might sometimes result in duplicate entries in the OID list,
> +    * but we don't care.
>       */
>
> This looks totally incoherent.  You've removed the thing to which the
> word "this" referred and replaced it with nothing.

Oops.
    /*     * The loop below runs multiple SELECTs might sometimes result in     * duplicate entries in the OID list,
butwe don't care.     */
 

looks reasonable?

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res
Next
From: Andres Freund
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics