Postgres Pro
Downloads
Home   >   mailing lists

PostgreSQL source code: copy command - Mailing list pgsql-novice

From Adam Dziedzic
Subject PostgreSQL source code: copy command
Date
Msg-id 55F31370.2010109@gmail.com
Whole thread Raw
Responses Re: PostgreSQL source code: copy command  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-novice
Tree view
Hello,

in file: /src/backend/command/copy.c
I found that it can happen that there is nothing in the buffer (fe_msgbuf) to be written to a file and there is only a check of count (which in this case would be 0):

498  if (fwrite(fe_msgbuf->data, fe_msgbuf->len, 1,
499  cstate->copy_file) != 1 ||
500  ferror(cstate->copy_file))
501

Maybe, before the fwrite we should check if fe_msgbuf->len > 0.

--
With kind regards,
Adam Dziedzic
Attachment

pgsql-novice by date:

Previous
From: James Keener
Date:
Subject: Re: PostgreSQL, JDBC and BObj
Next
From: Tom Lane
Date:
Subject: Re: PostgreSQL source code: copy command