Re: PostgreSQL source code: copy command - Mailing list pgsql-novice

From Tom Lane
Subject Re: PostgreSQL source code: copy command
Date
Msg-id 7409.1441995142@sss.pgh.pa.us
Whole thread Raw
In response to PostgreSQL source code: copy command  (Adam Dziedzic <adam.dziedzi@gmail.com>)
List pgsql-novice
Adam Dziedzic <adam.dziedzi@gmail.com> writes:
> in file: /src/backend/command/copy.c
> I found that it can happen that there is nothing in the buffer
> (fe_msgbuf) to be written to a file and there is only a check of count
> (which in this case would be 0):

> 498  if (fwrite(fe_msgbuf->data, fe_msgbuf->len, 1,
> 499  cstate->copy_file) != 1 ||
> 500  ferror(cstate->copy_file))

On what grounds do you claim that control can reach there without any
data in the buffer?  AFAICS, there must be at least either a row header
(if binary mode) or trailer (if not).

            regards, tom lane


pgsql-novice by date:

Previous
From: Adam Dziedzic
Date:
Subject: PostgreSQL source code: copy command
Next
From: Bastiaan Olij
Date:
Subject: Combining insert rules on views with functions