Re: BRIN INDEX value - Mailing list pgsql-hackers

On 9/4/2015 8:28 AM, Tatsuo Ishii wrote:
>>
>> Attached hack fixes the symptom but perhaps not the correct fix for this.
>
> Why can't we fix summarize_range() in brin.c:
>
>     IndexBuildHeapRangeScan(heapRel, state->bs_irel, indexInfo, false, true,
>                             heapBlk, state->bs_pagesPerRange,
>                             brinbuildCallback, (void *) state);
>
> This currently thoughtlessly passes scannumblocks as
> state->bs_pagesPerRange. Shouldn't we change this so that
> (scanStartBlock + scanNumBlocks) does not exceed scan->rs_nblocks?
>

Ah, it did cross my mind to the fix it in brin.c but was not sure. I did
it that way in the attached patch.

Thanks,
Amit