Re: BUG #12379: pgbench should hint to pgbench -i - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: BUG #12379: pgbench should hint to pgbench -i
Date
Msg-id 55D87918.6030805@iki.fi
Whole thread Raw
In response to Re: BUG #12379: pgbench should hint to pgbench -i  (Julien Rouhaud <julien.rouhaud@dalibo.com>)
Responses Re: BUG #12379: pgbench should hint to pgbench -i
List pgsql-bugs
On 07/18/2015 05:16 PM, Julien Rouhaud wrote:
> On 18/07/2015 13:49, Fabien COELHO wrote:
>>
>> Hello Julien,
>>
>>> Here's a v7 patch which display the hint only if SQLSTATE is
>>> ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
>>> wasn't any better suggestion or strong objection with it in the other
>>> thread.
>>
>> I'm wondering why you added the define. Isn't-there some convenient
>> include to get errcode definitions?
>
> IIRC correctly, you have to include postgres.h for that.  I supposed it
> was better to define it than adding such an include, since it shouldn't
> change and it's already done like this in vacuumdb.c.

Ok, committed.

- Heikki

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #13579: Server crashes after executing plpythonu function
Next
From: Fabien COELHO
Date:
Subject: Re: BUG #12379: pgbench should hint to pgbench -i