Re: BUG #12379: pgbench should hint to pgbench -i - Mailing list pgsql-bugs

From Fabien COELHO
Subject Re: BUG #12379: pgbench should hint to pgbench -i
Date
Msg-id alpine.DEB.2.10.1508222126270.11010@sto
Whole thread Raw
In response to Re: BUG #12379: pgbench should hint to pgbench -i  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-bugs
Hello Heikki,

>>>> Here's a v7 patch which display the hint only if SQLSTATE is
>>>> ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
>>>> wasn't any better suggestion or strong objection with it in the other
>>>> thread.
>>>
>>> I'm wondering why you added the define. Isn't-there some convenient
>>> include to get errcode definitions?
>>
>> IIRC correctly, you have to include postgres.h for that.  I supposed it
>> was better to define it than adding such an include, since it shouldn't
>> change and it's already done like this in vacuumdb.c.
>
> Ok, committed.

Thanks. Note that the author of the final version of the patch is mostly
Julien, who implemented Tom's suggested improvement, rather than myself.

--
Fabien.

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: BUG #12379: pgbench should hint to pgbench -i
Next
From: av.kostromin@gmail.com
Date:
Subject: BUG #13584: Upsert. The sequence value is increased.