Re: [PATCH] Microvacuum for gist. - Mailing list pgsql-hackers

On Mon, Aug 3, 2015 at 12:27 PM, Anastasia Lubennikova <a.lubennikova@postgrespro.ru> wrote:

1) Test and results are in attachments. Everything seems to work as expected.
2) I dropped these notices. It was done only for debug purposes. Updated patch is attached.
3) fixed

Good! Another couple of notes from me:

1) I think gistvacuumpage() and gistkillitems() need function-level comments.

2) ItemIdIsDead() can be used in index scan like it's done in _bt_checkkeys().

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

 

I've added some comments.
ItemIdIsDead() is used now (just skip dead tuples as not matching the quals).
And there is one else check of LSN in gistkillitems to make sure that page was not changed between reads.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company