Re: Applying XLR_INFO_MASK correctly when looking at WAL record information - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Applying XLR_INFO_MASK correctly when looking at WAL record information
Date
Msg-id 5571.1478280549@sss.pgh.pa.us
Whole thread Raw
In response to Applying XLR_INFO_MASK correctly when looking at WAL record information  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Applying XLR_INFO_MASK correctly when looking at WAL record information  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> I have just been trapped by the fact that in some code paths we look
> at the RMGR information of a WAL record (record->xl_info) but the
> filter dedicated to it, ~XLR_INFO_MASK, is not applied. This is
> harmful now, but this could lead to problems if in the future new
> record-level flags, similar to XLR_SPECIAL_REL_UPDATE, are added.
> Disclaimer: I am looking at a patch where a record-level flag makes
> sense, still this looks like a separate problem.

> What about the patch attached to make things more consistent?

Grepping found a couple of additional places that needed the same
fix.  Pushed with those additions.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: delta relations in AFTER triggers
Next
From: Amit Kapila
Date:
Subject: Re: Hash Indexes