Re: Small memory leak in execute.c of ECPG driver - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Small memory leak in execute.c of ECPG driver
Date
Msg-id 54D217CB.2090105@vmware.com
Whole thread Raw
In response to Re: Small memory leak in execute.c of ECPG driver  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 02/03/2015 02:45 PM, Michael Paquier wrote:
> On Tue, Feb 3, 2015 at 5:35 PM, Heikki Linnakangas
> <hlinnakangas@vmware.com>  wrote:
>> >I think there are more similar leaks nearby. After the first hunk, there's
>> >another if-check with "return false" that also leaks mallocedval. Right
>> >after the two other hunks, if the ecpg_realloc fails, we again leak
>> >mallocedval.
> Yes, I found some extra ones by re-reading the code again with newcopy
> (2) as well as mallocedval (1) as you mentioned.

Committed, along with more fixes for leaks on ecpg_realloc failures.

- Heikki




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Unnecessary pointer-NULL checks in pgp-pgsql.c
Next
From: Stephen Frost
Date:
Subject: Re: pg_dump's aborted transactions