Re: Build broken since 9aaa062 because of missing isnan and isinf - Mailing list pgsql-odbc

From Heikki Linnakangas
Subject Re: Build broken since 9aaa062 because of missing isnan and isinf
Date
Msg-id 54CA2D64.2070908@vmware.com
Whole thread Raw
In response to Re: Build broken since 9aaa062 because of missing isnan and isinf  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Build broken since 9aaa062 because of missing isnan and isinf  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-odbc
On 01/29/2015 01:51 PM, Michael Paquier wrote:
> On Thu, Jan 29, 2015 at 8:34 PM, Heikki Linnakangas
> <hlinnakangas@vmware.com> wrote:
>> Oh, thanks, fixed. I vaguely remembered that Windows doesn't have those
>> macros, but it actually worked on my Windows system. Maybe they've added
>> them to the MSVC headers recently...
> Yes, they have been added in MS 2013. I think that my patch is
> actually a bit wrong, we may want to use _MSC_VER < 1800 as well.

Good point. I'm seeing a compiler warning on my system now, about
redefining isnan and isinf. I rewrote the #ifdef as:

#if defined(WIN32) && !defined(isnan)

That seems to fix the warnings.

- Heikki



pgsql-odbc by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Regression tests
Next
From: Tom Lane
Date:
Subject: Re: Build broken since 9aaa062 because of missing isnan and isinf