Re: tracking commit timestamps - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: tracking commit timestamps
Date
Msg-id 5457F2F3.6070308@gmx.net
Whole thread Raw
In response to Re: tracking commit timestamps  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: tracking commit timestamps
Re: tracking commit timestamps
List pgsql-hackers
On 11/1/14 8:04 AM, Petr Jelinek wrote:
> On second thought, maybe those should be pg_get_transaction_committs,
> pg_get_transaction_committs_data, etc.

Please don't name anything "committs".  That looks like a misspelling of
something.

There is nothing wrong with

pg_get_transaction_commit_timestamp()

If you want to reduce the length, lose the "get".

> For me the commit time thing feels problematic in the way I perceive it
> - I see commit time as a point in time, where I see commit timestamp (or
> committs for short) as something that can recorded. So I would prefer to
> stick with commit timestamp/committs.

In PostgreSQL, it is pretty clearly established that time is hours,
minutes, seconds, and timestamp is years, months, days, hours, minutes,
seconds.  So unless this feature only records the hour, minute, and
second of a commit, it should be "timestamp".




pgsql-hackers by date:

Previous
From: Alexey Vasiliev
Date:
Subject: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Next
From: Peter Eisentraut
Date:
Subject: Re: TAP test breakage on MacOS X