Missing FIN_CRC32 calls in logical replication code - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Missing FIN_CRC32 calls in logical replication code
Date
Msg-id 544E23C0.8090605@vmware.com
Whole thread Raw
Responses Re: Missing FIN_CRC32 calls in logical replication code
List pgsql-hackers
replication/slot.c and replication/logical/snapbuild.c use a CRC on the 
physical slot and snapshot files. It uses the same algorithm as used 
e.g. for the WAL. However, they are not doing the finalization step, 
FIN_CRC32() on the calculated checksums. Not that it matters much, but 
it's a bit weird and inconsistent, and was probably an oversight.

- Heikki



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Function array_agg(array)
Next
From: Atri Sharma
Date:
Subject: Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT