On 09/03/2014 06:09 PM, Devrim Gündüz wrote:
> On Mon, 2014-09-01 at 14:52 +0800, Craig Ringer wrote:
>
>> I've prepped a patch incorporating some of the changes from the
>> unified spec, sticking to bug fixes and an update to beta2, per the
>> changelogs.
>
> The patch did not apply to my copy, since it seems you did not have the
> latest version.
I forgot to "git svn rebase" after I fetched changes. Whoops. Sorry.
> I did not apply:
>
> * I am not in favor of removing uuid conditional. Some people may be
> using it.
No complaint here. It seemed useless to have it when it'll build
unconditionally now, as if it's defined but no longer used it'll just
get ignored by RPM. But I don't have any complaint about keeping it,
it's just noise.
> * I did not apply the _isa related part. Packages like OpenOffice.org
> requires "postgresql-libs" for example, and that is all. If we provide
> the full version, we may break them (at least this is what I noticed a
> year or two ago)
There are two separate things in that change, and I probably should've
sent a patch series. I'm just not used to working with svn, even via
git-svn.
The extra %{?_isa} Provides: should be applied, as they're an
incompatibility between PGDG RPMs and Red Hat's. RPM automatically adds
these Provides to a package, but not to explicit Provides: lines. So
right now:
$ repoquery -q --provides postgresql
postgresql = 9.3.5-1.fc20
postgresql(x86-32) = 9.3.5-1.fc20
but:
$ sudo repoquery -q --provides postgresql93
postgresql
postgresql93 = 9.3.5-1PGDG.f20
postgresql93(x86-64) = 9.3.5-1PGDG.f20
and IMO, that's wrong. We should at minimum provide "postgresql(x86-32)".
Adding new Provides: cannot cause incompatibilities, so I think the
(versioned) %{?_isa} provides should be added to improve compatibility
with stock Fedora. However, since nobody's actually complaining about
them being missing, it's a bit academic until other packagers start
fixing their packages to follow Fedora packaging guidelines and add
%{?_isa} to their arch-sensitive Requires: lines like for postgresql-libs .
Separately, there's versioning the existing Provides: lines. I'm quite
confident that can't cause incompatibilities either as a versioned
Provides: satisfies an unversioned Requires: but not vice-versa, and
IIRC a versioned Requires: is not satisfied by an unversioned Provides .
So I'll follow up on this once I've done som VM testing.
>> pg_upgrade support is still broken, per
>> http://www.postgresql.org/message-id/53DBA105.3080004@2ndquadrant.com
>
> I'm at London this week, that is why some of your email are still
> pending for review.
Thanks. I know there's no real rush, I'm just in a position where I have
time to do some of this at the moment.
>> I also have no way to fix the java dependency bug as it's caused by
>> build-time problems.
>
> I'll look at it later.
Thanks.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
