Re: adding partitioned tables to publications - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: adding partitioned tables to publications
Date
Msg-id 537f34c5-0029-faf2-d14a-af4fb766b467@2ndquadrant.com
Whole thread Raw
In response to Re: adding partitioned tables to publications  (Rafia Sabih <rafia.pghackers@gmail.com>)
Responses Re: adding partitioned tables to publications  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On 2020-01-07 15:18, Rafia Sabih wrote:
> On Tue, 7 Jan 2020 at 06:02, Amit Langote <amitlangote09@gmail.com> wrote:
> 
>> Rebased and updated to address your comments.
>>
> +  <para>
> +   Partitioned tables are not considered when <literal>FOR ALL TABLES</literal>
> +   is specified.
> +  </para>
> +
> What is the reason for above, I mean not for the comment but not
> including partitioned tables in for all tables options.

This comment is kind of a noop, because the leaf partitions are already 
included in FOR ALL TABLES, so whether partitioned tables are considered 
included in FOR ALL TABLES is irrelevant.  I suggest removing the 
comment to avoid any confusion.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: adding partitioned tables to publications
Next
From: Heikki Linnakangas
Date:
Subject: Re: Fastpath while arranging the changes in LSN order in logicaldecoding