Re: New repmgr packages - Mailing list pgsql-pkg-yum

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

El 20/03/14 17:40, Devrim GÜNDÜZ escribió:
>
>> Another thing missing is the PGDG tag in Release.
>
> We add PGDG only to PostgreSQL itself. The rest does not belong to
> PGDG, so...

I'm not very involved on this and I might be missing some piece of
information, but why does the the Debian packages have the pgdg tag on
the name while the RHEL don't?

I personally think that we have to differentiate pgdg packages from
others. Unless this is not at all pgdg, but a personal package from
Devrim, which is also cool, but when multiple packages for the same
source come up, there has to be a way to discriminate one from the other.

>> I also saw some dependencies which were there before, but aren't
>> anymore (rsync for example, and also openssh (which was
>> mistakenly openssl before))
>
> Ah.. Good catch. Created #164 for this:
> http://wiki.pgrpms.org/ticket/164

To be more accurate, we need these dependencies:

BuildRequires:  postgresql%{pgpackageversion}-devel libxslt-devel
openssl-devel
Requires:       postgresql%{pgpackageversion}-server libxslt openssh rsync

There was a missing "-devel" in the postgres package in the BuildRequires.

>> I'm sending a patch for repmgr.spec with what I'm pointing out
>> here.
>>
>> I also changed a few things to make it look more like the
>> postgresql-X.Y.spec files.
>
> Do you mean these?
>
> -%global pgmajorversion 91 -%global pginstdir /usr/pgsql-9.1
> +%global pgmajorversion 9.1 +%define pgpackageversion 91 +%global
> pginstdir /usr/pgsql-%{pgmajorversion}
>
> If so, our version is exactly the same as in the other packages.
> We don't have pgpackageversion parameter anywhere. Am I missing
> something?

It makes it easier to define paths and so later, but....

But now that I think about it, and also talking to some of the
packagers from Debian, we could just build one repmgr and place the
binaries in /usr/bin/ (which is what Debian does).

This would reduce tremendously things related to different versions of
PostgreSQL in the spec file.

Thoughts?

Regards,

- --
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTMe8mAAoJEHsDtEgBAFTSm3kH/At3BXlOLJtorjtO1cYJUizq
qaX0duJXY11NIQYtoZQPXJYz1cOPB0oGAUj49hnqjJNZJzlCpRKJObZ4PnJbsqfj
MKNygIsgPzJ2b3TkaefyxAcG3TtZ2z+C8BoerBm8g+S2wnhgYpUe9zgZzUS0GHTM
5SkpnqbyofQik9Ge2+eaTGMeWrb/737xdN+McsFqQsaWWVRRLPWU9huWh6zXfsHg
1SlLiS78z56x2gB5ZSf3A01DUjwGNuW0ITjF6qkqber2C7BSfw83BViYCf8QViiT
CWjbeBltGjvHFzKU2FFbqUC4C5U9x61T6zAEppV9O/MLhi0OdCaLTPE0Qb90agA=
=OjnE
-----END PGP SIGNATURE-----