Re: -d option for pg_isready is broken - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: -d option for pg_isready is broken
Date
Msg-id 528BAC6F.7070806@agliodbs.com
Whole thread Raw
In response to -d option for pg_isready is broken  (Josh Berkus <josh@agliodbs.com>)
Responses Re: -d option for pg_isready is broken  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 11/19/2013 10:12 AM, Robert Haas wrote:
> On Tue, Nov 19, 2013 at 1:10 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Tue, Nov 19, 2013 at 11:51 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> On Fri, Nov 15, 2013 at 9:01 PM, Fabrízio de Royes Mello
>>> http://www.postgresql.org/docs/9.3/static/app-pg-isready.html
>>
>> Attached is the updated version of the patch. Is there any other bug?
>
> Not that I can see, but it's not very future-proof.  If libpq changes
> its idea of what will provoke database-name expansion, this will again
> be broken.

Why aren't we using the exact same code as psql?  Why does pg_isready
have its own code for this?

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block
Next
From: Andres Freund
Date:
Subject: Re: Data corruption issues using streaming replication on 9.0.14/9.2.5/9.3.1