Re: PostgreSQL 9.3 beta breaks some extensions "make install" - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: PostgreSQL 9.3 beta breaks some extensions "make install"
Date
Msg-id 5191A84D.7000704@dunslane.net
Whole thread Raw
In response to Re: PostgreSQL 9.3 beta breaks some extensions "make install"  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: PostgreSQL 9.3 beta breaks some extensions "make install"  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On 05/13/2013 10:27 PM, Peter Eisentraut wrote:
> On Tue, 2013-05-14 at 04:12 +0300, Marti Raudsepp wrote:
>> It's caused by this common pattern in extension makefiles:
>> DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql
>>
> What is the point of this?  Why have the wildcard and then the
> non-wildcard term?
>
> I think using wildcard is bad style and you should fix it.
>

I've been caught by it. I'm not sure why the wildcard is a bad idea - 
don't we want any present update sql files to be installed? . I don't 
see any reason to have the redundant addition of the current version's 
sql file, though.

cheers

andrew





pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Next
From: Peter Eisentraut
Date:
Subject: Re: commit fest schedule for 9.4