Re: Small psql memory fix - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Small psql memory fix
Date
Msg-id 511.1392438529@sss.pgh.pa.us
Whole thread Raw
In response to Small psql memory fix  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Small psql memory fix  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> The attached tiny patch fixes a small leak in psql's \gset command and
> simplifies memory freeing in two places.

The first and third hunks look to me like they introduce memory
leaks, not fix them.  The second hunk is probably safe enough,
although I'm not sure the case can actually occur --- gset should
free the prefix before any new backslash command can be executed.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication
Next
From: Bruce Momjian
Date:
Subject: Re: Small psql memory fix