On 11/12/12 7:59 PM, Amit kapila wrote:
> On Monday, November 12, 2012 12:07 PM Greg Smith wrote:
> On 11/9/12 11:59 PM, Amit kapila wrote:
>
>>> Please let me know if there are any objections or problems in above method of implementation,
>>> else I can go ahead to prepare the patch for the coming CF.
>
>> It may be the case that the locking scheme Robert described is the best
>> approach here. It seems kind of heavy to me though. I suspect that
>> some more thinking about it might come up with something better.
So, here's the problem I'm seeing with having a single .auto file: when
we write settings to a file, are we writing a *single* setting or *all
of a user's current settings*?
I was imagining writing single, specific settings, which inevitably
leads to one-setting-per-file, e.g.:
SET PERSISTENT work_mem = 256MB;
What Amit seems to be talking about is more EXPORT SETTINGS, where you
dump all current settings in the session to a file. This seems likely
to produce accidental changes when the user writes out settings they've
forgotten they changed.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
