pg_upgrade tests vs alter generic changes - Mailing list pgsql-hackers

The recent alter generic tests have broken pg_upgrade testing on Windows 
and probably other non-collation-supporting platforms. This can be cured 
by making the pg_upgrade test set up its test installs with "initdb 
--no-locale." as shown below (with similar changes for the MSVC  build 
system also being needed)

Is there any reason we don't want to do that, or to restrict it to just 
those platforms?

cheers

andrew


diff --git a/contrib/pg_upgrade/test.sh b/contrib/pg_upgrade/test.sh
index 32fb6bf..96da6f1 100644
--- a/contrib/pg_upgrade/test.sh
+++ b/contrib/pg_upgrade/test.sh
@@ -64,7 +64,7 @@ mkdir "$logdir"
 set -x

-$oldbindir/initdb -N
+$oldbindir/initdb -N --no-locale $oldbindir/pg_ctl start -l "$logdir/postmaster1.log" -o '-F' -w if "$MAKE" -C
"$oldsrc"installcheck; then        pg_dumpall -f "$temp_root"/dump1.sql || pg_dumpall1_status=$?
 
@@ -104,7 +104,7 @@ fi
 mv "${PGDATA}" "${PGDATA}.old"

-initdb -N
+initdb -N --no-locale
 pg_upgrade -d "${PGDATA}.old" -D "${PGDATA}" -b "$oldbindir" -B "$bindir"