Re: [HACKERS] Patching dblink.c to avoid warning about open transaction - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Patching dblink.c to avoid warning about open transaction
Date
Msg-id 5021.1128700793@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Patching dblink.c to avoid warning about open  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] Patching dblink.c to avoid warning about open  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> The problem with not using rconn is that we are not saving the
> transaction status at the _start_ of the cursor open.  If we don't do
> that, we have no way of knowing on close if _we_ opened the transaction
> or whether it was opened by the user.

Oh, I see.  In that case the flag is horribly misnamed and miscommented.
Something like "newXactForCursor" would be clearer.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about open
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about open