Re: [HACKERS] Patching dblink.c to avoid warning about open - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Patching dblink.c to avoid warning about open
Date
Msg-id 200510071605.j97G5Gj06255@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Patching dblink.c to avoid warning about open transaction  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The problem with not using rconn is that we are not saving the
> > transaction status at the _start_ of the cursor open.  If we don't do
> > that, we have no way of knowing on close if _we_ opened the transaction
> > or whether it was opened by the user.
>
> Oh, I see.  In that case the flag is horribly misnamed and miscommented.
> Something like "newXactForCursor" would be clearer.

OK, renamed to isClientXact.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about open transaction
Next
From: Bruce Momjian
Date:
Subject: Re: [BUGS] BUG #1927: incorrect timestamp returned