Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add compat file for dynamically loading the functions that MinGW - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Date
Msg-id 5019.1193666044@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Add compat file for dynamically loading the functions that MinGW  (mha@postgresql.org (Magnus Hagander))
Responses Re: pgsql: Add compat file for dynamically loading the functions that MinGW
List pgsql-committers
Tree view 
mha@postgresql.org (Magnus Hagander) writes:
> Add compat file for dynamically loading the functions that MinGW is missing
> the imports for. Add RegisterWaitForSingleObject() to the list of such
> functions, which should take care of the current buildfarm breakage.

Trivial stylistic complaint: shouldn't the _RegisterWaitForSingleObject
variable be declared static?  IMHO variables (and functions) should
always be static unless there is an explicit intent to access them from
other modules.

            regards, tom lane

pgsql-committers by date:

Previous
From: teodor@postgresql.org (Teodor Sigaev)
Date:
Subject: pgsql: Fix coredump during replay WAL after crash.
Next
From: Magnus Hagander
Date:
Subject: Re: pgsql: Add compat file for dynamically loading the functions that MinGW