Re: pgsql: Add compat file for dynamically loading the functions that MinGW - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Date
Msg-id 4725E86D.2010802@hagander.net
Whole thread Raw
In response to Re: pgsql: Add compat file for dynamically loading the functions that MinGW  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
>> Add compat file for dynamically loading the functions that MinGW is missing
>> the imports for. Add RegisterWaitForSingleObject() to the list of such
>> functions, which should take care of the current buildfarm breakage.
>
> Trivial stylistic complaint: shouldn't the _RegisterWaitForSingleObject
> variable be declared static?  IMHO variables (and functions) should
> always be static unless there is an explicit intent to access them from
> other modules.

Yup, it certainly should. Fixing. Thanks.

//Magnus

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Next
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Make variable static, per Tom.