Re: Fix logging for invalid recovery timeline - Mailing list pgsql-hackers

From Benoit Lobréau
Subject Re: Fix logging for invalid recovery timeline
Date
Msg-id 4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com
Whole thread Raw
In response to Re: Fix logging for invalid recovery timeline  (David Steele <david@pgbackrest.org>)
Responses Re: Fix logging for invalid recovery timeline
List pgsql-hackers
Hi,

I think the changes make sense. Would it be helpful to add the origin of 
the checkpoint record we are referring to ? (i.e. control file or backup 
label).

For example:

* Latest checkpoint in the control file is at %X/%X on timeline %u,
* Checkpoint location in the backup_label file is at %X/%X on timeline %u,

The current message refers to "Latest checkpoint" which automatically 
makes me think about the control file (specifically, the pg_controldata 
output).

Now that I have read the code, I understand which one we are referring 
to, but for someone who hasn't (or me in a few month) it might be useful ?

-- 
Benoit Lobréau
Consultant
http://dalibo.com




pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Improve statistics estimation considering GROUP-BY as a 'uniqueiser'
Next
From: Bertrand Drouvot
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart