Re: Fix logging for invalid recovery timeline - Mailing list pgsql-hackers

From David Steele
Subject Re: Fix logging for invalid recovery timeline
Date
Msg-id 2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org
Whole thread Raw
In response to Re: Fix logging for invalid recovery timeline  (Benoit Lobréau <benoit.lobreau@dalibo.com>)
Responses Re: Fix logging for invalid recovery timeline
List pgsql-hackers
On 2/19/25 03:51, Benoit Lobréau wrote:
> 
> I think the changes make sense. Would it be helpful to add the origin of 
> the checkpoint record we are referring to ? (i.e. control file or backup 
> label).
> 
> For example:
> 
> * Latest checkpoint in the control file is at %X/%X on timeline %u,
> * Checkpoint location in the backup_label file is at %X/%X on timeline %u,

I like this idea but I would prefer to get the patch committed as-is 
first. The reason is that I'm hoping to see this batch-patched (since it 
is a bug) and that is less likely if the message wording is change.

Your idea would be perfect going forward, though.

Regards,
-David



pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: why there is not VACUUM FULL CONCURRENTLY?
Next
From: Marcos Pegoraro
Date:
Subject: Re: why there is not VACUUM FULL CONCURRENTLY?