Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove useless arguments in ReadCheckpointRecord(). - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Remove useless arguments in ReadCheckpointRecord().
Date
Msg-id 4c27fe77-c1c9-b1aa-d6cf-b6e840a9f6ce@oss.nttdata.com
Whole thread Raw
In response to Re: Remove useless arguments in ReadCheckpointRecord().  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Remove useless arguments in ReadCheckpointRecord().
List pgsql-hackers
Tree view 

On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
> I believed that it is recommended to move to the style not having the
> outmost parens.  That style has been introduced by e3a87b4991.

I read the commit log, but I'm not sure yet if it's really recommended to remove extra parens even from the existing
callsto errmsg(). Removing extra parens can interfere with back-patching of the changes around those errmsg(), can't
it?

Anyway, at first I pushed the 0001 patch that removes useless arguments in ReadCheckpointRecord().

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Next
From: Tom Lane
Date:
Subject: Re: Remove useless arguments in ReadCheckpointRecord().