Re: Remove useless arguments in ReadCheckpointRecord(). - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove useless arguments in ReadCheckpointRecord().
Date
Msg-id 1826703.1658716816@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove useless arguments in ReadCheckpointRecord().  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Remove useless arguments in ReadCheckpointRecord().
List pgsql-hackers
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
>> I believed that it is recommended to move to the style not having the
>> outmost parens.  That style has been introduced by e3a87b4991.

> I read the commit log, but I'm not sure yet if it's really recommended to remove extra parens even from the existing
callsto errmsg(). Removing extra parens can interfere with back-patching of the changes around those errmsg(), can't
it?

Right, so I wouldn't be in a hurry to change existing calls.  If you're
editing an ereport call for some other reason, it's fine to remove the
excess parens in it, because you're creating a backpatch hazard there
anyway.  But otherwise, I think such changes are make-work in themselves
and risk creating more make-work for somebody else later.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Remove useless arguments in ReadCheckpointRecord().
Next
From: Zhang Mingli
Date:
Subject: Re: ReadRecentBuffer() is broken for local buffer