Re: Remembering bug #6123 - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: Remembering bug #6123
Date
Msg-id 4F0F18880200002500044760@gw.wicourts.gov
Whole thread Raw
In response to Re: Remembering bug #6123  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remembering bug #6123  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Hmm, I would think you'd get assertion failures from calling
> HeapTupleHeaderGetCmax when xmax isn't the current transaction.
> (But I'm not sure that the regression tests really exercise such
> cases ... did you try the isolation tests with this?)  I was
> thinking we should probably define the cmax as being returned only
> in SelfUpdated cases.

You were right.  One of the isolation tests failed an assertion;
things pass with the attached change, setting the cmax
conditionally.  Some comments updated.  I hope this is helpful.  I
can't take more time right now, because we're getting major snowfall
and I've got to leave now to get home safely.

-Kevin


Attachment

pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Remembering bug #6123
Next
From: Alex Hunsaker
Date:
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.