Re: 16-bit page checksums for 9.2 - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: 16-bit page checksums for 9.2
Date
Msg-id 4F0402C60200002500044319@gw.wicourts.gov
Whole thread Raw
In response to 16-bit page checksums for 9.2  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Alvaro Herrera  wrote:
> We don't support BLCKSZ higher than 32k anyway
Thanks for pointing that out.  Then I think we should declare sum1 to
be uint and sum2 to be uint64.  We can take out the "% 255" out from
where it sits in the v2 patch, and just add something like this after
the sums are generated:   sum1 %= 255;   sum2 %= 255;
Or, of course, we can just do it on the line where we combine the two
sums for the final result, if that's not too hard to read.
-Kevin


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: 16-bit page checksums for 9.2
Next
From: "Albe Laurenz"
Date:
Subject: Re: review: CHECK FUNCTION statement