Re: new compiler warnings - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: new compiler warnings
Date
Msg-id 4E9D9C7A02000025000421D9@gw.wicourts.gov
Whole thread Raw
In response to Re: new compiler warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: new compiler warnings
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I don't think the assert is a good idea.  If it ever did happen,
> that would promote the problem from "corrupted data in the log" to
> "database crash".
... on a --enable-cassert build.
If we think it's even remotely possible that it could happen, maybe
we should do the loop.  That would change the current "missing log
information" situation to "interleaved log information".
But if we think it would be better for data to be missing from the
log than interleaved, the Assert could be removed and it still
suppresses the error (at least on my machine).
-Kevin


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: new compiler warnings
Next
From: Tom Lane
Date:
Subject: Re: termination of backend waiting for sync rep generates a junk log message