Re: new compiler warnings - Mailing list pgsql-hackers

From Tom Lane
Subject Re: new compiler warnings
Date
Msg-id 21875.1318969696@sss.pgh.pa.us
Whole thread Raw
In response to Re: new compiler warnings  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: new compiler warnings
Re: new compiler warnings
List pgsql-hackers
"Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
> Would it be too weird to do something like this for each?:
> -       write(fileno(stderr), line, len);
> +       rc = write(fileno(stderr), line, len);
> +       if (rc >= 0 && rc != len)
> +       {
> +           Assert(false);
> +           return;
> +       }

I don't think the assert is a good idea.  If it ever did happen, that
would promote the problem from "corrupted data in the log" to "database
crash".
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: new compiler warnings
Next
From: Heikki Linnakangas
Date:
Subject: Re: new compiler warnings