Re: new compiler warnings - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: new compiler warnings
Date
Msg-id 4E9D97C702000025000421CD@gw.wicourts.gov
Whole thread Raw
In response to Re: new compiler warnings  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: new compiler warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> wrote:
> Unfortunately, whether Tom's right or not, we still don't have a
> solution to the compiler warning.
Would it be too weird to do something like this for each?:
diff --git a/src/backend/utils/error/elog.c
b/src/backend/utils/error/elog.c
index f0b3b1f..bea5489 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -1747,6 +1747,7 @@ write_eventlog(int level, const char *line, int
len)static voidwrite_console(const char *line, int len){
+    ssize_t rc;#ifdef WIN32       /*
@@ -1794,7 +1795,12 @@ write_console(const char *line, int len)        */#endif
-       write(fileno(stderr), line, len);
+       rc = write(fileno(stderr), line, len);
+       if (rc >= 0 && rc != len)
+       {
+           Assert(false);
+           return;
+       }}/*
-Kevin


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: new compiler warnings
Next
From: Tom Lane
Date:
Subject: Re: new compiler warnings