Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Date
Msg-id 4E19F236.4080507@agliodbs.com
Whole thread Raw
In response to Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected  (Florian Pflug <fgp@phlo.org>)
Responses Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
List pgsql-hackers
Hackers,

>> B. 6. Current behaviour _is intended_ (there is "if"  to check node type) and _"natural"_. In this particular case
userask for text content of some node, and this content is actually "<".
 
> 
> I don't buy that. The check for the node type is there because
> two different libxml functions are used to convert nodes to
> strings. The if has absolutely *zero* to do with escaping, expect
> for that missing escape_xml() call in the "else" case.
> 
> Secondly, there is little point in having an type XML if we
> don't actually ensure that values of that type can only contain
> well-formed XML.

Can anyone else weigh in on this? Peter?


-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: patch for distinguishing PG instances in event log
Next
From: Josh Berkus
Date:
Subject: Re: Small patch for GiST: move childoffnum to child