Postgres Pro
Downloads
Home   >   mailing lists

Re: Small patch for GiST: move childoffnum to child - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Small patch for GiST: move childoffnum to child
Date
Msg-id 4E19F2C2.9010001@agliodbs.com
Whole thread Raw
In response to Re: Small patch for GiST: move childoffnum to child  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: Small patch for GiST: move childoffnum to child
List pgsql-hackers
Tree view 
Teodor, Oleg, Heikki,

> My concern is that I am unable to prove to myself simply by reading
> the code that the 24 line chunk deleted from gistFindPath (near ***
> 919,947 ****) are no longer needed.  My familiarity with the gist code
> is low enough that it is not surprising that I cannot prove this to
> myself from first principles.  I have no reason to believe it is not
> correct, it is just that I can't convince myself that it is correct.

Can one of you weigh in on Jeff's concern here about this patch?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Next
From: Josh Berkus
Date:
Subject: Re: Re: patch review : Add ability to constrain backend temporary file space