Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Date
Msg-id 1310645733.16381.3.camel@fsopti579.F-Secure.com
Whole thread Raw
In response to Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
List pgsql-hackers
On sön, 2011-07-10 at 11:40 -0700, Josh Berkus wrote:
> Hackers,
> 
> >> B. 6. Current behaviour _is intended_ (there is "if"  to check node type) and _"natural"_. In this particular case
userask for text content of some node, and this content is actually "<".
 
> > 
> > I don't buy that. The check for the node type is there because
> > two different libxml functions are used to convert nodes to
> > strings. The if has absolutely *zero* to do with escaping, expect
> > for that missing escape_xml() call in the "else" case.
> > 
> > Secondly, there is little point in having an type XML if we
> > don't actually ensure that values of that type can only contain
> > well-formed XML.
> 
> Can anyone else weigh in on this? Peter?

Looks like a good change to me.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected
Next
From: Radosław Smogura
Date:
Subject: Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected