Kevin,
thanks for your heads-up.
On 01/26/2011 06:07 PM, Kevin Grittner wrote:
> Simon Riggs <simon@2ndQuadrant.com> wrote:
>
>> I looked at the patch to begin a review and immediately saw
>> "dtest". There's no docs to explain what it is, but a few comments
>> fill me in a little more. Can we document that please? And/or
>> explain why its an essential part of this commit? Could we keep it
>> out of core, or if not, just commit that part separately? I notice
>> the code is currently copyright someone else than PGDG.
>
> I'm including Markus on this reply, because he's the only one who
> can address the copyright issue.
I certainly agree to change the copyright notice for my parts of the
code in Kevin's SSI to say "Copyright ... Postgres Global Development
Group".
However, it's also worth mentioning that 'make dcheck' requires my
dtester python package to be installed. See [1]. I put that under the
Boost license, which seems very similar to the Postgres license.
> When I suggested breaking this out of the patch, everybody who spoke
> up said not to do so. How the eventual committer commits it is of
> course up to that person.
If the committer decides not to commit the dtests, I'm happy to add
these dtests to the "official" postgres-dtests repository [2]. There I
could let it follow the development of dtester.
If Kevin's dtests gets committed, either dtester needs to be backwards
compatible or the Postgres sources need to follow development of
dtester, which I'm not satisfied with, yet. (However, note that I
didn't have any time to work on dtester, recently, so that is somewhat
hypothetical anyway).
If you have any more questions, I'm happy to help.
Regards
Markus Wanner
[1]: dtester project site:
http://www.bluegap.ch/projects/dtester/
[2]: postgres dtests:
http://git.postgres-r.org/?p=postgres-dtests;a=summary
