Re: Complier warnings on mingw gcc 4.5.0 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Complier warnings on mingw gcc 4.5.0
Date
Msg-id 4D0960E5.8050104@dunslane.net
Whole thread Raw
In response to Re: Complier warnings on mingw gcc 4.5.0  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Complier warnings on mingw gcc 4.5.0  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 12/15/2010 07:24 PM, Tom Lane wrote:
>
> So I concur with the previous suggestions:
>
> 1. Make this problem go away by forcing use of our getopt code on
> mingw.
>
> 2. Make sure we reset optreset when using our code.  (Probably not
> really necessary, but let's just be careful.)
>
> Should we backpatch either of these things?
>
>             

Yes. We need it to back at least to 9.0.

I believe #2 is in fact necessary. When I tried just #1 before it 
failed. What's the best way to do #2 cleanly?

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Complier warnings on mingw gcc 4.5.0
Next
From: Andrew Dunstan
Date:
Subject: Re: Complier warnings on mingw gcc 4.5.0