Re: Complier warnings on mingw gcc 4.5.0 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Complier warnings on mingw gcc 4.5.0
Date
Msg-id 14352.1292459093@sss.pgh.pa.us
Whole thread Raw
In response to Re: Complier warnings on mingw gcc 4.5.0  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Complier warnings on mingw gcc 4.5.0  (Andrew Dunstan <andrew@dunslane.net>)
Re: Complier warnings on mingw gcc 4.5.0  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 12/15/2010 06:42 PM, Tom Lane wrote:
>> Hm, where did you get this?

> I downloaded 
>
<http://softlayer.dl.sourceforge.net/project/mingw/MinGW/BaseSystem/RuntimeLibrary/MinGW-RT/mingwrt-3.18/mingwrt-3.18-mingw32-src.tar.gz>

> which is allegedly the source for the latest released runtime.

Huh, I wonder why it doesn't match what's in sourceforge CVS?

Anyway, the short answer is that this code has got no visible
commonality with glibc's getopt(), so we need not fear that what
it's doing is likely to start happening elsewhere.  I didn't take
the time to trace through the glibc code exactly; I figure the lack
of trouble reports is sufficient proof that we're not doing anything
that it won't cope with.

So I concur with the previous suggestions:

1. Make this problem go away by forcing use of our getopt code on
mingw.

2. Make sure we reset optreset when using our code.  (Probably not
really necessary, but let's just be careful.)

Should we backpatch either of these things?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Complier warnings on mingw gcc 4.5.0
Next
From: Andrew Dunstan
Date:
Subject: Re: Complier warnings on mingw gcc 4.5.0