Re: pg_execute_from_file review - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pg_execute_from_file review
Date
Msg-id 4CF3D285.8010801@dunslane.net
Whole thread Raw
In response to Re: pg_execute_from_file review  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_execute_from_file review
List pgsql-hackers

On 11/29/2010 11:12 AM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> I'm not sure why you need either "from". It just seems like a noise
>> word. Maybe we could use pg_execute_query_file() and
>> pg_execute_query_string(), which would be fairly clear and nicely
>> symmetrical.
> +1, but I think "query" is also a noise word here.
> Why not just "pg_execute_file" and "pg_execute_string"?
>
>             

Well, I put that in to make it clear that the file/string is expected to 
contain SQL and not, say, machine code. But I agree we could possibly do 
without it.

cheers

andrew


pgsql-hackers by date:

Previous
From: Joshua Tolley
Date:
Subject: Re: pg_execute_from_file review
Next
From: Tom Lane
Date:
Subject: Re: pg_execute_from_file review