Re: testing cvs HEAD - HS/SR - missing file - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: testing cvs HEAD - HS/SR - missing file
Date
Msg-id 4B602587.5070703@enterprisedb.com
Whole thread Raw
In response to Re: testing cvs HEAD - HS/SR - missing file  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: testing cvs HEAD - HS/SR - missing file  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao wrote:
> On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> Before that, endptr is advanced using XLByteAdvance() macro, which does
>> handle xlogid boundaries. Is XLByteAdvance() broken?
> 
> No. The cause of the bug is that endptr might be set to the SendRqstPtr
> that has crossed a xlogid boundary in the following code.
> 
>>         /* if we went beyond SendRqstPtr, back off */
>>         if (XLByteLT(SendRqstPtr, endptr))
>>             endptr = SendRqstPtr;

But SendRqstPtr comes from LogwrtResult.Write, surely that's correct, no?

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Martin Atukunda
Date:
Subject: Re: Patch: psql \whoami option
Next
From: Magnus Hagander
Date:
Subject: Re: Patch: psql \whoami option